DataGrid - Focused cell highlight on sticky columns is still visible even when the focused cell is outside the viewport (T1310313)#33284
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a DataGrid sticky-columns focus-overlay behavior where the focused cell highlight could remain visible on sticky columns even after the focused cell scrolls out of the viewport.
Changes:
- Removed the sticky-columns-specific
getFocusOverlayContaineroverride so the focus overlay uses the base EditorFactory container logic.
| // @ts-expect-error | ||
| return this.getOverlayContainerIfNeeded($cell) ?? super.getRevertButtonContainer($cell); | ||
| } | ||
|
|
||
| protected getFocusOverlayContainer($focusedElement: dxElementWrapper): dxElementWrapper { | ||
| return this.getOverlayContainerIfNeeded($focusedElement) | ||
| ?? super.getFocusOverlayContainer($focusedElement); | ||
| } | ||
|
|
||
| protected overlayPositionedHandler(e, isOverlayVisible: boolean): void { |
There was a problem hiding this comment.
This change alters how the focused cell overlay chooses its container for sticky columns (by removing the sticky-columns-specific getFocusOverlayContainer override). There are no regression tests covering the reported scenario (focused cell moved outside the viewport while sticky columns remain visible). Please add a QUnit test (e.g. in DevExpress.ui.widgets.dataGrid/stickyColumns.tests.js or focus-related DataGrid tests) that scrolls horizontally so the focused cell is out of view and asserts the focus overlay/highlight is not visible on the sticky area.
No description provided.